Skip to content

Add CSS variables for color-theme options#268

Open
mirisuzanne wants to merge 2 commits intomainfrom
color-themes
Open

Add CSS variables for color-theme options#268
mirisuzanne wants to merge 2 commits intomainfrom
color-themes

Conversation

@mirisuzanne
Copy link
Copy Markdown
Member

@mirisuzanne mirisuzanne commented Mar 11, 2018

This is one proposal for allowing basic color-theme options, as per #252. The variables provided, and their default values currently:

:root {
  // use these to adjust global colors…
  --color-theme-dark: #0d7fa5;
  --color-theme-light: #cfe5ed;
  --color-contrast-light: #fff;
  --color-contrast-low: #555b5e;
  --color-contrast-dark: #3b4042;
  --color-accent-dark: #aa0e5c;
  --color-accent-light: #eac3d6;

  // use these for more control over how colors are used…
  --color-background: var(--color-contrast-light);
  --color-text: var(--color-contrast-dark);
  --color-text-light: var(--color-contrast-low);
  --color-sidebar-background: var(--color-theme-dark);
  --color-sidebar-text: var(--color-contrast-light);
  --color-action: var(--color-accent-dark);
  --color-focus: var(--color-theme-dark);
  --color-underline: var(--color-accent-light);
  --color-border: var(--color-callout);
  --color-callout: var(--color-theme-light);
  --color-callout-text: var(--color-text);
}
  • If we like this approach, we need to determine the API:
    • do I change them directly in the herman config settings?
    • do I pass in a Sass file containing overrides?
    • should we also have themes to choose from e.g.: default, light, and dark?
  • document whatever API we land on…

@jgerigmeyer jgerigmeyer changed the base branch from master to main January 4, 2021 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants